Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct preserveScrollPosition calculation in nested controllers #320

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Correct preserveScrollPosition calculation in nested controllers #320

wants to merge 2 commits into from

Conversation

Gaurav0
Copy link

@Gaurav0 Gaurav0 commented Mar 6, 2023

For #319

@Gaurav0 Gaurav0 force-pushed the correct_nested_controller_preserveScrollPosition branch from a34bfe9 to c47a107 Compare March 6, 2023 20:33
@Gaurav0
Copy link
Author

Gaurav0 commented Mar 6, 2023

Tests passing here: https://github.com/Gaurav0/ember-router-scroll/actions/runs/4347756710/jobs/7595437061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gaurav0